Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved rotation during export #118

Draft
wants to merge 3 commits into
base: 1.21
Choose a base branch
from
Draft

Improved rotation during export #118

wants to merge 3 commits into from
+40 −5

Conversation

Minenash
Copy link

@Minenash Minenash commented Sep 25, 2024 •
edited
Loading

  • When animated export started, it resets the rotation offset
  • When exporting, changes rotation by a consistent amount instead of using LastFrameDuration
  • When exporting, tickcounter uses a consistent amount of time based on the export framerate
    • This solves weird jumps in exported rotations when there is some lag

The only worry I have, is that magic number 20. At least for me it matches what LastFrameDuration would be assuming no lag, but I'm not sure if there are times where this number would be wrong

@Minenash Minenash marked this pull request as draft September 30, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Minenash